Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StorageImpl #1667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

FroGitHub
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the StorageImpl class! 🎉 Your code meets all the task requirements and constraints effectively. While there are some minor issues related to type safety with generic arrays, they don't impact the core functionality of your solution. Keep up the good work and consider exploring safer alternatives for handling generics in the future to enhance your code's robustness. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +13 to +14
keys = (K[]) new Object[MAX_SIZE];
values = (V[]) new Object[MAX_SIZE];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using generic arrays like (K[]) new Object[MAX_SIZE] can lead to unchecked warnings because Java doesn't allow the creation of generic arrays directly. Consider using an ArrayList or another collection that can handle generics more safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants