Implemented the Storage #1669
Implemented the Storage #1669
Conversation
There was a problem hiding this comment.
Great job on implementing the StorageImpl class! 🎉 Your code meets all the task requirements and constraints, and you've done well to avoid common mistakes. While there are some minor improvements suggested regarding object comparison using equals() instead of ==, these don't impact the core functionality. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @Override | ||
| public void put(K key, V value) { | ||
| for (int i = 0; i < counter; i++) { | ||
| if (key == dataOfKeys[i]) { |
There was a problem hiding this comment.
Using == to compare objects is not recommended for non-primitive types. This should be replaced with equals() to properly compare the contents of the objects.
| if (key == dataOfKeys[i]) { | ||
| dataOfValues[i] = value; | ||
| return; | ||
| } else if (key != null && key.equals(dataOfKeys[i])) { |
There was a problem hiding this comment.
This check for key.equals(dataOfKeys[i]) is correct, but the previous == check is redundant for non-primitive types. Consider removing the == check and using only equals() for object comparison.
| } | ||
|
|
||
| @Override | ||
| public V get(K key) { | ||
| for (int i = 0; i < counter; i++) { | ||
| if (key == dataOfKeys[i]) { |
There was a problem hiding this comment.
Similar to the put method, using == for object comparison is not appropriate here. Use equals() instead to compare the key with dataOfKeys[i].
| for (int i = 0; i < counter; i++) { | ||
| if (key == dataOfKeys[i]) { | ||
| return dataOfValues[i]; | ||
| } else if (key != null && key.equals(dataOfKeys[i])) { |
There was a problem hiding this comment.
This equals() check is correct, but the == check above is redundant for non-primitive types. Consider removing the == check and using only equals() for object comparison.
| public StorageImpl() { | ||
| dataOfKeys = (K[]) new Object[MAX_ITEMS_NUMBER]; | ||
| dataOfValues = (V[]) new Object[MAX_ITEMS_NUMBER]; | ||
| counter = 0; |
| private K[] dataOfKeys; | ||
| private V[] dataOfValues; | ||
| private int counter; |
There was a problem hiding this comment.
| private K[] dataOfKeys; | |
| private V[] dataOfValues; | |
| private int counter; | |
| private K[] keys; | |
| private V[] values; | |
| private int size; |
| @Override | ||
| public void put(K key, V value) { | ||
| for (int i = 0; i < counter; i++) { | ||
| if (key == dataOfKeys[i]) { |
There was a problem hiding this comment.
let's create separate method indexOf() to avoid duplication of code in put and get methods
| @Override | ||
| public void put(K key, V value) { | ||
| if (indexOf(key) != -1) { |
There was a problem hiding this comment.
create local variable, don't need to call indexOf method twice
| } | ||
|
|
||
| @Override | ||
| public V get(K key) { | ||
| if (indexOf(key) != -1) { |
| if (key == keys[i]) { | ||
| return i; | ||
| } else if (key != null && key.equals(keys[i])) { | ||
| return i; | ||
| } |
There was a problem hiding this comment.
| if (key == keys[i]) { | |
| return i; | |
| } else if (key != null && key.equals(keys[i])) { | |
| return i; | |
| } | |
| if (key == keys[i] || key != null && key.equals(keys[i])) { | |
| return i; | |
| } |
No description provided.