new solve #1671
Open
new solve #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Great job on implementing the StorageImpl class! 🎉 Your solution meets all the task requirements and constraints effectively. The use of arrays for key-value storage and the handling of updates are well done. Just a small suggestion: consider using equals() for key comparison to handle object keys more reliably. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @Override | ||
| public void put(K key, V value) { | ||
| for (int i = 0; i < size; i++) { | ||
| if ((keys[i] == key) || (keys[i] != null && keys[i].equals(key))) { |
There was a problem hiding this comment.
The comparison (keys[i] == key) checks for reference equality, which might not be appropriate for all types of keys. Consider using only keys[i].equals(key) for object comparison to ensure logical equality is checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.