Implemented the Storage of the key-value #1674
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this implementation! 😊 While your code meets many of the task requirements, there are a couple of critical issues that need to be addressed to ensure the functionality is robust and aligns with the expected behavior:
-
Handling Duplicate
nullKeys: Theputmethod currently allows multiplenullkeys to be stored. This could lead to unexpected behavior, as typically, a storage system should not allow duplicate keys. Please add a check to prevent storing duplicatenullkeys. -
Full Storage Handling: The
putmethod does not currently handle the situation where the storage is full. This could lead to errors or data loss if new entries are added beyond the storage capacity. Consider implementing a mechanism to handle this scenario, such as throwing an exception or ignoring new entries when the storage is full.
Once these issues are resolved, your implementation will be much stronger and ready for approval. Keep up the great work, and don't hesitate to reach out if you have any questions or need further guidance! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| if (size < MAX_SIZE) { | ||
| keys[size] = key; | ||
| values[size] = value; | ||
| size++; | ||
| } |
There was a problem hiding this comment.
The put method does not handle the case when the storage is full and a new key-value pair is attempted to be added. Consider adding a condition to handle this scenario, such as throwing an exception or ignoring the new entry.
| if (key == null) { | ||
| for (int i = 0; i < size; i++) { | ||
| K targetKey = keys[i]; | ||
| if (targetKey == null) { | ||
| values[i] = value; | ||
| return; | ||
| } | ||
| } | ||
| keys[size] = null; | ||
| values[size] = value; | ||
| size++; |
There was a problem hiding this comment.
When the key is null, the put method does not check for duplicate null keys. This could lead to multiple null keys being stored, which may not be the intended behavior. Consider adding a check to prevent duplicate null keys.
There was a problem hiding this comment.
Review Summary
Great job on implementing the StorageImpl class! 🎉 Your code meets the task requirements and constraints, effectively handling full storage by throwing an exception and using arrays without collections. Here are some key points and areas for improvement:
-
Handling Duplicate
nullKeys: You've made progress by checking for existingnullkeys and updating their values. However, ensure that no duplicatenullkeys are stored to prevent unexpected behavior. -
Full Storage Handling: Excellent work on throwing a
RuntimeExceptionwhen the storage is full, which is a suitable approach for this scenario. -
Code Structure: Your use of arrays, initialization in the constructor, and avoidance of magic numbers are commendable. The code is concise, with clear and informative naming.
While the implementation is correct and meets the specified requirements, addressing the issue with duplicate null keys will enhance the robustness of your solution. Keep up the great work, and continue refining your skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (key == null) { | ||
| for (int i = 0; i < size; i++) { | ||
| if (keys[i] == null) { | ||
| values[i] = value; | ||
| return; | ||
| } | ||
| } | ||
| keys[size] = null; |
There was a problem hiding this comment.
The current implementation allows multiple null keys to be stored. According to the task requirements, you should prevent storing duplicate null keys. Consider adding a check to ensure that a null key is not added if it already exists in the storage.
No description provided.