first solution #1682
Open
first solution #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slade13
approved these changes
Feb 3, 2025
| private int index; | ||
|
|
||
| public StorageImpl() { | ||
| int maxArrSize = 10; |
There was a problem hiding this comment.
Replace this local variable with constant field: private static final int MAX_SIZE = 10;.
|
|
||
| public class StorageImpl<K, V> implements Storage<K, V> { | ||
| private Object[] keys; | ||
| private Object[] values; | ||
| private int index; |
There was a problem hiding this comment.
Rename this variable, so the name will better suit it's purpose.
Suggested change
| private int index; | |
| private int size; |
Comment on lines
+28
to
+30
| keys[index] = key; | ||
| values[index] = value; | ||
| index++; |
There was a problem hiding this comment.
Add check to ensure that maximum capacity is not exceeded.
Suggested change
| keys[index] = key; | |
| values[index] = value; | |
| index++; | |
| if (size < MAX_SIZE) { | |
| keys[size] = key; | |
| values[size] = value; | |
| size++; | |
| } else { | |
| throw new IllegalStateException("Storage is full. Maximum capacity is " + MAX_SIZE); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.