Implement the Storage of the key-value type #1684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Great job on implementing the StorageImpl! 🎉 While there are a few minor issues like the misspelling of capacity and handling full storage more appropriately, these don't critically impact the functionality. Keep up the good work and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| public class StorageImpl<K, V> implements Storage<K, V> { | ||
| private static final int capasity = 10; |
There was a problem hiding this comment.
The variable capasity is misspelled. It should be capacity.
Comment on lines
31
to
32
| } else { | ||
| System.out.println("Storage is full"); |
There was a problem hiding this comment.
Printing a message when the storage is full is not a good practice. Consider throwing an exception or handling this case more appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.