Solution #1499
Solution #1499
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 The code meets all the task requirements and constraints effectively. While there are a couple of minor issues, such as the misspelling of chache and a suggestion to use "".join() for cleaner cache key generation, these do not impact the functionality. Keep up the good work, and consider these suggestions for even cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| def cache(func: Callable) -> Callable: | ||
| # Write your code here | ||
| pass | ||
| chache = {} |
There was a problem hiding this comment.
The variable chache is misspelled. It should be cache to correctly reflect its purpose.
| chache = {} | ||
|
|
||
| def wrapper(*args, **kwargs): | ||
| func_code = str(func.__name__) + str(args) + str(kwargs) |
There was a problem hiding this comment.
The comment on line 3 suggests using "".join(func.__name__, args, kwargs) for the cache key. While the current implementation using string concatenation works, using join might be cleaner and more in line with the comment.
No description provided.