Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1503

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1503

wants to merge 3 commits into from

Conversation

vladoromus
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements and constraints, and it's clear that you've put a lot of effort into ensuring it works correctly with multiple functions and handles caching efficiently. Just a small note: be cautious when using mutable types as keys in dictionaries, as this can lead to unexpected behavior. Consider ensuring that args is always a tuple of immutable types to avoid any hashing issues. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


@wraps(func)
def wrapper(*args: Tuple[Any, ...]) -> Any:
if args in cache_store:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mutable types as keys in a dictionary can lead to unexpected behavior. Ensure that args is always a tuple of immutable types to avoid issues with hashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants