-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1900
base: master
Are you sure you want to change the base?
solution #1900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your code is beautiful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Car
and CarWashStation
classes! 🎉 The code meets the task requirements and constraints, and the methods perform as expected. While there are minor suggestions for improvement, such as refactoring to avoid redundancy and ensuring the washing price formula aligns with the task requirements, these do not impact the core functionality. Keep up the good work, and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
def calculate_washing_price(self, car: Car) -> float: | ||
income = (car.comfort_class * (self.clean_power - car.clean_mark) | ||
* (self.average_rating / self.distance)) | ||
return round(income, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formula for calculating the washing price seems to be complex. Ensure that this formula is correct according to the task requirements. If the task specifies a different calculation method, adjust it accordingly.
if car.clean_mark < self.clean_power: | ||
car.clean_mark = self.clean_power |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition if car.clean_mark < self.clean_power:
is checked twice, once in serve_cars
and again in wash_single_car
. Consider refactoring to avoid redundancy, unless this is intentional for the task requirements.
No description provided.