-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1912
base: master
Are you sure you want to change the base?
solution #1912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks clean. Great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Car
and CarWashStation
classes! 🎉 Your solution meets the task requirements and constraints effectively. While there is a minor suggestion to improve code readability by removing unnecessary else
statements after a return
, this does not impact the functionality. Keep up the good work and continue refining your coding style for even cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
def wash_single_car(self, car: Car) -> int: | ||
if car.clean_mark < self.clean_power: | ||
car.clean_mark = self.clean_power | ||
else: | ||
return car.clean_mark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the wash_single_car
method, the return statement should be placed outside the else
block. According to the checklist, you can avoid using else
when you have a return statement. This will make the code cleaner and more readable.
No description provided.