Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1695

wants to merge 1 commit into from

Conversation

RifatN1996
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Distance class with all the required functionalities! 🎉 The code meets the task requirements and constraints, and you've done well with operator overloading and type annotations. Just a small note: consider adding a return NotImplemented at the end of the __truediv__ method to handle unsupported types gracefully. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +36 to +39
def __truediv__(self, other: Any) -> Distance:
if isinstance(other, (int, float)):
return Distance(round(self.km / other, 2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __truediv__ method is missing a return statement for cases where other is not an int or float. You should add return NotImplemented at the end of this method to handle unsupported types properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants