'Solution' #1702
'Solution' #1702
Conversation
There was a problem hiding this comment.
Your implementation of the Distance class is well-done and meets the task requirements! 🎉 The class handles arithmetic operations and comparisons effectively. While there is a minor suggestion to improve the type hints for better clarity and to remove some unnecessary else statements, these do not impact the functionality. Keep up the great work, and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| km=self.km + other | ||
| ) | ||
|
|
||
| def __iadd__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| self.km = self.km + other | ||
| return self | ||
|
|
||
| def __mul__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| def __mul__(self, other: int) -> "Distance": | ||
| return Distance(km=self.km * other) | ||
|
|
||
| def __truediv__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| def __truediv__(self, other: int) -> "Distance": | ||
| return Distance(km=round(self.km / other, 2)) | ||
|
|
||
| def __lt__(self, other: int) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| else: | ||
| return self.km < other | ||
|
|
||
| def __gt__(self, other: int) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| else: | ||
| return self.km > other | ||
|
|
||
| def __eq__(self, other: int) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| else: | ||
| return self.km == other | ||
|
|
||
| def __le__(self, other: int) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
| else: | ||
| return self.km <= other | ||
|
|
||
| def __ge__(self, other: int) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter should include both Distance and int, as the method is designed to handle both types. Consider changing it to Union[Distance, int].
No description provided.