Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1710

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,45 @@
class Distance:
# Write your code here
pass
def __init__(self, km: int) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: (int, float)) -> "Distance":
if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)

def __iadd__(self, other: (int, float)) -> (int, float):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type of the __iadd__ method should be Distance, not (int, float). According to the task description, this method should return the modified instance of Distance.

if isinstance(other, Distance):
self.km += other.km
return self
elif isinstance(other, (int, float)):
self.km += other
return self

def __mul__(self, other: (int, float)) -> "Distance":
if isinstance(other, (int, float)):
return Distance(self.km * other)

def __truediv__(self, other: (int, float)) -> "Distance":
return Distance(round(self.km / other, 2))

def __lt__(self, other: (int, float)) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __lt__ method should be able to compare with both Distance objects and numeric types. Currently, it only compares with numeric types. You should add a check to handle Distance objects as well.

return self.km < other

def __gt__(self, other: (int, float)) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __gt__ method should be able to compare with both Distance objects and numeric types. Currently, it only compares with numeric types. You should add a check to handle Distance objects as well.

return self.km > other

def __eq__(self, other: (int, float)) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __eq__ method should be able to compare with both Distance objects and numeric types. Currently, it only compares with numeric types. You should add a check to handle Distance objects as well.

return self.km == other

def __le__(self, other: (int, float)) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __le__ method should be able to compare with both Distance objects and numeric types. Currently, it only compares with numeric types. You should add a check to handle Distance objects as well.

return self.km <= other

def __ge__(self, other: int) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __ge__ method should be able to compare with both Distance objects and numeric types. Currently, it only compares with numeric types. You should add a check to handle Distance objects as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter type hint for the __ge__ method is inconsistent with the other comparison methods. It should allow both Distance objects and numeric types, similar to the other methods.

return self.km >= other