Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1714

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 43 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,44 @@
class Distance:
# Write your code here
pass
def __init__(self, km: int) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicate that km can be either float or int here and in the other places

self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: int) -> object:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicate that other can be either float, int or Distance class instance here and in the other places. Correct your return type annotation as well to indicate that method will return Distance class instance in all corresponding methods

if isinstance(other, Distance):
return Distance(self.km + other.km)
if isinstance(other, (int, float)):
return Distance(self.km + other)

def __iadd__(self, other: int) -> object:
if isinstance(other, Distance):
self.km += other.km
return self
if isinstance(other, (int, float)):
self.km += other
return self

def __mul__(self, other: int) -> object:
return Distance(self.km * other)

def __truediv__(self, value: int) -> object:
return Distance(round(self.km / value, 2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __truediv__ method should handle division by zero to prevent runtime errors. Consider adding a check to ensure value is not zero before performing the division.


def __lt__(self, other: int) -> bool:
return self.km < other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __lt__ method should compare Distance objects, not just integers. Consider checking if other is an instance of Distance and compare self.km with other.km.


def __gt__(self, other: int) -> bool:
return self.km > other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __gt__ method should compare Distance objects, not just integers. Consider checking if other is an instance of Distance and compare self.km with other.km.


def __eq__(self, other: int) -> bool:
return self.km == other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __eq__ method should compare Distance objects, not just integers. Consider checking if other is an instance of Distance and compare self.km with other.km.


def __le__(self, other: int) -> bool:
return self.km <= other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __le__ method should compare Distance objects, not just integers. Consider checking if other is an instance of Distance and compare self.km with other.km.


def __ge__(self, other: int) -> bool:
return self.km >= other
vladoromus marked this conversation as resolved.
Show resolved Hide resolved