implemented py-distance-class #1716
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 The functionality is mostly correct, and you've done well with operator overloading and type annotations. There are just a couple of minor improvements to consider: updating the type hint for the __eq__ method to include int and float, and fixing the missing parenthesis in the __iadd__ method's type hint. These tweaks will enhance the code's clarity and robustness. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __iadd__(self, other: Distance | int | float | ||
| ) -> Distance | int | float: |
There was a problem hiding this comment.
There is a missing closing parenthesis in the type hint for the __iadd__ method. It should be Distance | int | float) instead of Distance | int | float.
| else: | ||
| raise TypeError("Type is not correct") | ||
|
|
||
| def __eq__(self, other: Distance) -> bool: |
There was a problem hiding this comment.
The type hint for the __eq__ method should include int and float since the method implementation allows comparison with these types. Update the type hint to Distance | int | float.
No description provided.