solution #1107
solution #1107
Conversation
There was a problem hiding this comment.
Great job on implementing the core functionality! 🎉 While there are some minor improvements suggested, such as using a list of tuples for actors and ensuring migrations are included, these do not critically impact the functionality. Keep up the good work and consider the feedback for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
|
|
||
| def main() -> QuerySet: | ||
| pass | ||
| for genre in ["Western", "Action", "Dramma"]: |
There was a problem hiding this comment.
There is a typo in the genre name 'Dramma'. It should be 'Drama'. However, this is corrected later in the code, so it doesn't affect the final result.
| for actor in ["George Klooney", "Kianu Reaves", | ||
| "Scarlett Keegan", "Will Smith", | ||
| "Jaden Smith", "Scarlett Johansson"]: |
There was a problem hiding this comment.
Consider using a list of tuples for actors, where each tuple contains the first and last name. This would eliminate the need to split the names later.
| Actor.objects.filter( | ||
| first_name="Scarlett", | ||
| ).delete() |
There was a problem hiding this comment.
The deletion of actors with the first name 'Scarlett' will remove both 'Scarlett Keegan' and 'Scarlett Johansson'. Ensure this is the intended behavior.
No description provided.