Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #1108

wants to merge 2 commits into from

Conversation

nrjss67
Copy link

@nrjss67 nrjss67 commented Dec 2, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the models and main function logic! 🎉 While there are a few minor issues, such as the use of a list of tuples and a for loop for better code structure, these don't critically impact the functionality of your code. Remember to correct any typos at the creation stage to maintain data accuracy. Keep up the good work, and consider these suggestions for future improvements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


Genre.objects.create(name="Western")
Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the genre name 'Dramma'. It should be 'Drama'. This is corrected later in the code, but it's better to create it correctly from the start.

Genre.objects.create(name="Western")
Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")
Actor.objects.create(first_name="George", last_name="Klooney")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the actor's last name 'Klooney'. It should be 'Clooney'. This is corrected later in the code, but it's better to create it correctly from the start.

Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")
Actor.objects.create(first_name="George", last_name="Klooney")
Actor.objects.create(first_name="Kianu", last_name="Reaves")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the actor's first name 'Kianu' and last name 'Reaves'. They should be 'Keanu' and 'Reeves', respectively. This is corrected later in the code, but it's better to create it correctly from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants