Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

'Solution' #1109

wants to merge 2 commits into from

Conversation

Carn1vor3
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the models and main function! 🎉 While there are a few minor spelling errors and a typo in the initial data, these don't critically impact the functionality of your code. Just keep an eye on those details in the future to make your code even more efficient. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨



def main() -> QuerySet:
pass
genres = ["Western", "Action", "Dramma"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The genre 'Dramma' seems to be a typo. It is later updated to 'Drama', but it would be better to correct it initially to avoid unnecessary updates.

for genre in genres:
Genre.objects.create(name=genre)

actors = ["George Klooney",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name 'George Klooney' is misspelled. It should be 'George Clooney'. This is corrected later, but it would be more efficient to use the correct name initially.

Genre.objects.create(name=genre)

actors = ["George Klooney",
"Kianu Reaves",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name 'Kianu Reaves' is misspelled. It should be 'Keanu Reeves'. This is corrected later, but it would be more efficient to use the correct name initially.

"Jaden Smith",
"Scarlett Johansson"]
for actor in actors:
first_name, last_name = actor.split()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that all actor names in the list have exactly two parts (first and last name) to avoid errors when splitting the string. If any name has more than two parts, this line will raise a ValueError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants