Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions db/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Generated by Django 4.0.2 on 2024-12-05 10:16

from django.db import migrations, models


class Migration(migrations.Migration):

initial = True

dependencies = [
]

operations = [
migrations.CreateModel(
name='Actor',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('first_name', models.CharField(max_length=255)),
('last_name', models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name='Genre',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255)),
],
),
]
9 changes: 9 additions & 0 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255)


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)
35 changes: 34 additions & 1 deletion main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,39 @@

from django.db.models import QuerySet

from db.models import Genre, Actor


def main() -> QuerySet:
pass

Genre.objects.create(name="Western")
Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")
idubina marked this conversation as resolved.
Show resolved Hide resolved
Actor.objects.create(first_name="George", last_name="Klooney")
idubina marked this conversation as resolved.
Show resolved Hide resolved
Actor.objects.create(first_name="Kianu", last_name="Reaves")
idubina marked this conversation as resolved.
Show resolved Hide resolved
Actor.objects.create(first_name="Scarlett", last_name="Keegan")
Actor.objects.create(first_name="Will", last_name="Smith")
Actor.objects.create(first_name="Jaden", last_name="Smith")
Actor.objects.create(first_name="Scarlett", last_name="Johansson")
Comment on lines +10 to +18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a list of tuples to store the genre and actor data, and iterate over them using a for loop. This will reduce code repetition and improve readability. For example, you can create a list like genres = ["Western", "Action", "Dramma"] and iterate over it to create Genre objects.


Genre.objects.filter(name="Dramma").update(name="Drama")

Actor.objects.filter(
first_name="George",
last_name="Klooney"
).update(
last_name="Clooney"
)

Actor.objects.filter(
first_name="Kianu",
last_name="Reaves"
).update(
first_name="Keanu",
last_name="Reeves"
)
Comment on lines +22 to +35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, consider using a list of tuples for the actor updates. This will make the code more concise and easier to manage. For example, you can create a list of tuples with the incorrect and correct names, and iterate over it to perform the updates.


Genre.objects.filter(name="Action").delete()
Actor.objects.filter(first_name="Scarlett").delete()
idubina marked this conversation as resolved.
Show resolved Hide resolved

return Actor.objects.filter(last_name="Smith").order_by("first_name")
Loading