Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution_v1.00' #1114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255)


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)
40 changes: 39 additions & 1 deletion main.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,45 @@
import init_django_orm # noqa: F401

from django.db.models import QuerySet
from db.models import Genre, Actor


def main() -> QuerySet:
pass

for gen in ["Western", "Action", "Dramma"]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The genre name 'Dramma' seems to be a typo. It is later updated to 'Drama', but it would be more consistent to use 'Drama' from the start.

Genre.objects.create(name=gen)

actors = [
("George", "Klooney"),
("Kianu", "Reaves"),
Comment on lines +13 to +14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names 'George Klooney' and 'Kianu Reaves' are likely typos. They are corrected later, but it would be more consistent to use 'George Clooney' and 'Keanu Reeves' from the start.

("Scarlett", "Keegan"),
("Will", "Smith"),
("Jaden", "Smith"),
("Scarlett", "Johansson")
]
for actor_fname, actor_sname in actors:
Actor.objects.create(first_name=actor_fname, last_name=actor_sname)

Genre.objects.filter(
name="Dramma"
).update(name="Drama")

Actor.objects.filter(
first_name="George",
last_name="Klooney"
).update(
last_name="Clooney"
)

Actor.objects.filter(
first_name="Kianu",
last_name="Reaves"
).update(
first_name="Keanu",
last_name="Reeves"
)

Genre.objects.filter(name="Action").delete()
Actor.objects.filter(first_name="Scarlett").delete()

return Actor.objects.filter(last_name="Smith").order_by("first_name")
Comment on lines 7 to +45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task explicitly states not to include the if __name__ == "__main__": main() fragment in main.py. Ensure that this fragment is not present in the file, as it was mentioned in the previous review.

2 changes: 1 addition & 1 deletion settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@

USE_TZ = False

INSTALLED_APPS = ("db",)
INSTALLED_APPS = ["db", ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settings.py file is not directly related to the task requirements. Consider removing it from the pull request unless it's necessary for testing or execution, as mentioned in the previous review.

Loading