Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255)


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)
25 changes: 24 additions & 1 deletion main.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,30 @@
import init_django_orm # noqa: F401

from django.db.models import QuerySet
from db.models import Genre, Actor


def main() -> QuerySet:
pass
Genre.objects.create(name="Western")
Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the genre name 'Dramma'. It should be 'Drama'. This is corrected later in the code, but it's better to create it correctly from the start.

Actor.objects.create(first_name="George", last_name="Klooney")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the actor's last name 'Klooney'. It should be 'Clooney'. This is corrected later in the code, but it's better to create it correctly from the start.

Actor.objects.create(first_name="Kianu", last_name="Reaves")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the actor's first name 'Kianu' and last name 'Reaves'. They should be 'Keanu' and 'Reeves', respectively. This is corrected later in the code, but it's better to create it correctly from the start.

Actor.objects.create(first_name="Scarlett", last_name="Keegan")
Actor.objects.create(first_name="Will", last_name="Smith")
Actor.objects.create(first_name="Jaden", last_name="Smith")
Actor.objects.create(first_name="Scarlett", last_name="Johansson")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task suggests using a list of tuples and a for loop to create objects, which helps avoid repetition and makes the code cleaner. Consider refactoring this part to improve code quality.

Genre.objects.filter(name="Dramma").update(name="Drama")
(Actor.objects.filter(first_name="George", last_name="Klooney").
update(last_name="Clooney"))
(Actor.objects.filter(first_name="Kianu", last_name="Reaves").
update(first_name="Keanu", last_name="Reeves"))
Genre.objects.filter(name="Action").delete()
Actor.objects.filter(first_name="Scarlett").delete()
Comment on lines +22 to +28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the operations performed here align with the task requirements. If the task specifies certain operations or constraints, make sure they are followed.

return Actor.objects.filter(last_name="Smith").order_by("first_name")


if __name__ == "__main__":
print(main())
print(Genre.objects.all())
print(Actor.objects.all())
Loading