Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1122

wants to merge 2 commits into from

Conversation

RToister
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets all the specified requirements. The models and migrations are correctly defined, and the database operations in main.py are well-handled. While the exception handling for deletion operations is unnecessary, it doesn't impact the functionality. Keep up the good work, and consider refining exception handling in future projects. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +49 to +52
try:
Genre.objects.filter(name="Action").delete()
except Genre.DoesNotExist:
print("Genre 'Action' not found.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Genre.DoesNotExist exception will not be raised by the filter().delete() method. This method does not raise exceptions if no records are found; it simply does nothing. Therefore, the try-except block is unnecessary here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants