-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1129
base: master
Are you sure you want to change the base?
solution #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 The models and main function are well-structured and meet the core requirements. While there are a few minor typos in names like 'Kianu', 'Klooney', and 'Dramma', these don't affect the overall functionality. Consider correcting these for consistency. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -1,7 +1,45 @@ | |||
import init_django_orm # noqa: F401 | |||
|
|||
from django.db.models import QuerySet | |||
from db.models import Actor, Genre | |||
|
|||
genres = ["Western", "Action", "Dramma"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the genre name 'Dramma'. It should be 'Drama' to match the corrected name later in the code.
from db.models import Actor, Genre | ||
|
||
genres = ["Western", "Action", "Dramma"] | ||
actors = [("George", "Klooney"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the actor's name 'Klooney'. It should be 'Clooney' to match the corrected name later in the code.
|
||
genres = ["Western", "Action", "Dramma"] | ||
actors = [("George", "Klooney"), | ||
("Kianu", "Reaves"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the actor's name 'Kianu'. It should be 'Keanu' to match the corrected name later in the code.
genres = ["Western", "Action", "Dramma"] | ||
actors = [("George", "Klooney"), | ||
("Kianu", "Reaves"), | ||
("Scarlett", "Keegan"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a potential issue with having two actors with the first name 'Scarlett'. This might lead to unintended deletions later in the code.
No description provided.