-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1157
base: master
Are you sure you want to change the base?
Solution #1157
Conversation
main.py
Outdated
Genre.objects.create(name="Western") | ||
Genre.objects.create(name="Action") | ||
Genre.objects.create(name="Dramma") | ||
Actor.objects.create( | ||
first_name="George", | ||
last_name="Klooney" | ||
) | ||
Actor.objects.create( | ||
first_name="Kianu", | ||
last_name="Reaves" | ||
) | ||
Actor.objects.create( | ||
first_name="Scarlett", | ||
last_name="Keegan" | ||
) | ||
Actor.objects.create( | ||
first_name="Will", | ||
last_name="Smith" | ||
) | ||
Actor.objects.create( | ||
first_name="Jaden", | ||
last_name="Smith" | ||
) | ||
Actor.objects.create( | ||
first_name="Scarlett", | ||
last_name="Johansson" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad practice, check сhapter 3 of checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check my coment and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 The models and main function are well-structured and meet the specified criteria. While there are minor typos in the initial data for 'Kianu Reaves' and 'Dramma', these don't impact the overall functionality. Consider correcting these typos in the initial data to streamline your code. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
genres_objects = [ | ||
{"name": "Western"}, | ||
{"name": "Action"}, | ||
{"name": "Dramma"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The genre name 'Dramma' seems to be a typo. It is later corrected to 'Drama' in the update operation on line 32. Ensure that the initial data is accurate to avoid unnecessary updates.
{"first_name": "George", "last_name": "Klooney"}, | ||
{"first_name": "Kianu", "last_name": "Reaves"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actor's name 'Kianu Reaves' appears to be a typo. It is later corrected to 'Keanu Reeves' in the update operation on lines 42-44. Consider correcting the initial data to avoid unnecessary updates.
No description provided.