Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1157

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Solution #1157

wants to merge 5 commits into from

Conversation

IvankaKuzin
Copy link

No description provided.

main.py Outdated
Comment on lines 8 to 35
Genre.objects.create(name="Western")
Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")
Actor.objects.create(
first_name="George",
last_name="Klooney"
)
Actor.objects.create(
first_name="Kianu",
last_name="Reaves"
)
Actor.objects.create(
first_name="Scarlett",
last_name="Keegan"
)
Actor.objects.create(
first_name="Will",
last_name="Smith"
)
Actor.objects.create(
first_name="Jaden",
last_name="Smith"
)
Actor.objects.create(
first_name="Scarlett",
last_name="Johansson"
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad practice, check сhapter 3 of checklist

Copy link

@MaksVakulenko MaksVakulenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check my coment and documentation

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The models and main function are well-structured and meet the specified criteria. While there are minor typos in the initial data for 'Kianu Reaves' and 'Dramma', these don't impact the overall functionality. Consider correcting these typos in the initial data to streamline your code. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

genres_objects = [
{"name": "Western"},
{"name": "Action"},
{"name": "Dramma"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The genre name 'Dramma' seems to be a typo. It is later corrected to 'Drama' in the update operation on line 32. Ensure that the initial data is accurate to avoid unnecessary updates.

Comment on lines +17 to +18
{"first_name": "George", "last_name": "Klooney"},
{"first_name": "Kianu", "last_name": "Reaves"},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actor's name 'Kianu Reaves' appears to be a typo. It is later corrected to 'Keanu Reeves' in the update operation on lines 42-44. Consider correcting the initial data to avoid unnecessary updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants