Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1 +1,13 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255)


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)

def __str__(self) -> str:
return f"{self.first_name} {self.last_name}"
32 changes: 31 additions & 1 deletion main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,36 @@

from django.db.models import QuerySet

from db.models import Genre, Actor


def main() -> QuerySet:
pass
Genre.objects.create(name="Western")
Genre.objects.create(name="Action")
Genre.objects.create(name="Dramma")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the genre name 'Dramma'. It should be 'Drama'. However, this is corrected later in the code, so it's not a critical issue but worth noting.

Actor.objects.create(first_name="George", last_name="Klooney")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the actor's last name 'Klooney'. It should be 'Clooney'. This is corrected later in the code, so it's not a critical issue but worth noting.

Actor.objects.create(first_name="Kianu", last_name="Reaves")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the actor's first name 'Kianu' and last name 'Reaves'. They should be 'Keanu' and 'Reeves', respectively. This is corrected later in the code, so it's not a critical issue but worth noting.

Actor.objects.create(first_name="Scarlett", last_name="Keegan")
Actor.objects.create(first_name="Will", last_name="Smith")
Actor.objects.create(first_name="Jaden", last_name="Smith")
Actor.objects.create(first_name="Scarlett", last_name="Johansson")

Genre.objects.filter(name="Dramma").update(name="Drama")
Actor.objects.filter(
first_name="George", last_name="Klooney"
).update(first_name="George", last_name="Clooney")
Actor.objects.filter(
first_name="Kianu", last_name="Reaves"
).update(first_name="Keanu", last_name="Reeves")

Genre.objects.filter(name="Action").delete()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletion of the 'Action' genre might affect other parts of the application if they rely on this genre. Ensure that this deletion is intentional and does not disrupt other functionalities.

Actor.objects.filter(first_name="Scarlett").delete()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting all actors with the first name 'Scarlett' will remove both 'Scarlett Keegan' and 'Scarlett Johansson'. Ensure that this is the intended behavior.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires deleting only actresses with the first name 'Scarlett'. Currently, the code deletes all actors with that name, which may not meet the task requirements. Please adjust the logic to ensure only actresses are deleted.


print(Actor.objects.all()) # Should show the actors if they were created
print(Genre.objects.all())

return Actor.objects.filter(last_name="Smith").order_by("first_name")


if __name__ == "__main__":
main()
Comment on lines +36 to +37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should not include the fragment if __name__ == "__main__": main(). Although it's commented out, it should be completely removed to comply with the checklist.

Loading