Merge pull request #117 from mate-academy/add-checkphrases #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added checklist.md
vsmutok
suggested changes
Sep 30, 2023
main.py
Outdated
Comment on lines
8
to
40
| Genre.objects.create( | ||
| name="Western", | ||
| ) | ||
| Genre.objects.create( | ||
| name="Action", | ||
| ) | ||
| Genre.objects.create( | ||
| name="Dramma", | ||
| ) | ||
| Actor.objects.create( | ||
| first_name="George", | ||
| last_name="Klooney", | ||
| ) | ||
| Actor.objects.create( | ||
| first_name="Kianu", | ||
| last_name="Reaves", | ||
| ) | ||
| Actor.objects.create( | ||
| first_name="Scarlett", | ||
| last_name="Keegan", | ||
| ) | ||
| Actor.objects.create( | ||
| first_name="Will", | ||
| last_name="Smith", | ||
| ) | ||
| Actor.objects.create( | ||
| first_name="Jaden", | ||
| last_name="Smith", | ||
| ) | ||
| Actor.objects.create( | ||
| first_name="Scarlett", | ||
| last_name="Johansson", | ||
| ) |
# Conflicts: # main.py
vasylhnatiuk
suggested changes
Oct 1, 2023
db/migrations/0001_initial.py
Outdated
|
|
||
| operations = [ | ||
| migrations.CreateModel( | ||
| name='Actor', |
main.py
Outdated
|
|
||
|
|
||
| def main() -> QuerySet: | ||
| pass | ||
| genre_list = ["Western", "Action", "Dramma"] | ||
| for objec_list in genre_list: |
main.py
Outdated
| ["Jaden", "Smith"], | ||
| ["Scarlett", "Johansson"] | ||
| ] | ||
| for objec1_list in actor_list: |
added 2 commits
October 1, 2023 12:54
vasylhnatiuk
suggested changes
Oct 1, 2023
main.py
Outdated
|
|
||
|
|
||
| def main() -> QuerySet: | ||
| pass | ||
| genre_list = ["Western", "Action", "Dramma"] |
There was a problem hiding this comment.
Suggested change
| genre_list = ["Western", "Action", "Dramma"] | |
| genres= ["Western", "Action", "Dramma"] |
main.py
Outdated
|
|
||
|
|
||
| def main() -> QuerySet: | ||
| pass | ||
| genre_list = ["Western", "Action", "Dramma"] | ||
| for data_genre in genre_list: |
There was a problem hiding this comment.
Suggested change
| for data_genre in genre_list: | |
| for genre in genres: |
main.py
Outdated
| ["Jaden", "Smith"], | ||
| ["Scarlett", "Johansson"] | ||
| ] | ||
| for data_actor in actor_list: |
There was a problem hiding this comment.
Suggested change
| for data_actor in actor_list: | |
| for first_name, last_name in actors: |
vasylhnatiuk
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added checklist.md