Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #536

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Solution #536

wants to merge 8 commits into from

Conversation

ladno338
Copy link

No description provided.

Даня Пономаренко added 2 commits October 17, 2023 15:38
Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests

Даня Пономаренко added 3 commits October 17, 2023 17:17
@ladno338 ladno338 requested a review from vasylhnatiuk October 17, 2023 14:51
main.py Outdated
["Scarlett", "Johansson"]]
for genre in list_of_genre:
Genre.objects.create(name=genre)
for actor in list_of_actors:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for actor in list_of_actors:
for first_name, last_name in list_of_actors:


operations = [
migrations.CreateModel(
name='Actor',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change ' to " , use Black

main.py Outdated


def main() -> QuerySet:
pass
# create
list_of_genre = ["Western", "Action", "Dramma"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
list_of_genre = ["Western", "Action", "Dramma"]
genres = ["Western", "Action", "Dramma"]

main.py Outdated
pass
# create
list_of_genre = ["Western", "Action", "Dramma"]
list_of_actors = [["George", "Klooney"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
list_of_actors = [["George", "Klooney"],
actors = [["George", "Klooney"],

@ladno338 ladno338 requested a review from vasylhnatiuk October 17, 2023 15:51
Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests

@ladno338 ladno338 requested a review from vasylhnatiuk October 17, 2023 18:00
main.py Outdated
["Scarlett", "Johansson"]]
for genre in genres:
Genre.objects.create(name=genre)
for actor in actors:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for actor in actors:
for first_name, last_name in actors:

main.py Outdated
for genre in genres:
Genre.objects.create(name=genre)
for actor in actors:
Actor.objects.create(first_name=actor[0], last_name=actor[1])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Actor.objects.create(first_name=actor[0], last_name=actor[1])
Actor.objects.create(first_name= first_name, last_name=last_name)

@ladno338 ladno338 requested a review from vasylhnatiuk October 17, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants