Solution #554
Closed
Solution #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlejviki
suggested changes
Oct 28, 2023
main.py
Outdated
| Actor.objects.create(first_name="Scarlett", last_name="Keegan") | ||
| Actor.objects.create(first_name="Will", last_name="Smith") | ||
| Actor.objects.create(first_name="Jaden", last_name="Smith") | ||
| Actor.objects.create(first_name="Scarlett", last_name="Johansson") |
There was a problem hiding this comment.
use a for loop to avoid code duplication
viktoria-rybenchuk
suggested changes
Oct 28, 2023
main.py
Outdated
|
|
||
|
|
||
| def main() -> QuerySet: | ||
| pass | ||
| for genre in ["Western", "Action", "Dramma"]: | ||
| Genre.objects.create(name=genre) |
There was a problem hiding this comment.
add a blank line between two logical parts of the code, you can simply insert a blank line to visually separate the sections.
main.py
Outdated
Comment on lines
10
to
17
| for first_name, last_name in [ | ||
| ["George", "Klooney"], | ||
| ["Kianu", "Reaves"], | ||
| ["Scarlett", "Keegan"], | ||
| ["Will", "Smith"], | ||
| ["Jaden", "Smith"], | ||
| ["Scarlett", "Johansson"] | ||
| ]: |
There was a problem hiding this comment.
To make the code more readable, you can save the list of first and last names in a variable and then use a for loop with that variable
| last_name="Reaves" | ||
| ).update(first_name="Keanu", last_name="Reeves") | ||
| Genre.objects.filter(name="Action").delete() | ||
| Actor.objects.filter(first_name="Scarlett").delete() |
There was a problem hiding this comment.
Add a blank line to separate sections of your code for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.