Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution 2 #1327

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 54 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,54 @@
# write your code here
class Animal:
alive = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alive list should be a class variable, not an instance variable. It should be defined as Animal.alive = [] outside of the class definition to ensure it is shared across all instances.

def __init__(self, name, health: int = 100, is_hidden: bool = False):
self.name = name
self.health = health
self.is_hidden = is_hidden
self.alive.append(self)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending self to self.alive is incorrect because alive should be accessed as a class variable. Use Animal.alive.append(self) instead.


def die(self):
if self in Animal.alive:
self.alive.remove(self)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the constructor, alive should be accessed as a class variable. Use Animal.alive.remove(self) instead.

def __repr__(self):
return f"Animal(name={self.name}, health={self.health}, hidden={self.is_hidden})"

@classmethod
def print_alive(cls):
return "\n".join(str(animal) for animal in cls.alive)


class Herbivore(Animal):

def hide(self) -> bool:
self.is_hidden = not self.is_hidden
return self.is_hidden


class Сarnivore(Animal):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Сarnivore uses a non-standard character for 'C'. Ensure you are using the correct 'C' character to avoid potential issues.

def bite(self, target):
if not target.is_hidden:
target.health -= 50
if target.health <= 0:
target.health = 0
target.die()
else:
target.health = 100

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here seems incorrect. If the target is hidden, its health should not be reset to 100. Consider revising this logic.




rabbit = Herbivore("Rabbit")
print(rabbit)
lion = Сarnivore("Lion")
print(lion)


lion.bite(rabbit)
print(rabbit.health)
lion.bite(rabbit)
print(rabbit.health)
print(Animal.alive)
Loading