-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution 2 #1327
base: master
Are you sure you want to change the base?
Solution 2 #1327
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,54 @@ | ||
# write your code here | ||
class Animal: | ||
alive = [] | ||
|
||
def __init__(self, name, health: int = 100, is_hidden: bool = False): | ||
self.name = name | ||
self.health = health | ||
self.is_hidden = is_hidden | ||
self.alive.append(self) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Appending |
||
|
||
def die(self): | ||
if self in Animal.alive: | ||
self.alive.remove(self) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the constructor, |
||
def __repr__(self): | ||
return f"Animal(name={self.name}, health={self.health}, hidden={self.is_hidden})" | ||
|
||
@classmethod | ||
def print_alive(cls): | ||
return "\n".join(str(animal) for animal in cls.alive) | ||
|
||
|
||
class Herbivore(Animal): | ||
|
||
def hide(self) -> bool: | ||
self.is_hidden = not self.is_hidden | ||
return self.is_hidden | ||
|
||
|
||
class Сarnivore(Animal): | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The class name |
||
def bite(self, target): | ||
if not target.is_hidden: | ||
target.health -= 50 | ||
if target.health <= 0: | ||
target.health = 0 | ||
target.die() | ||
else: | ||
target.health = 100 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic here seems incorrect. If the target is hidden, its health should not be reset to 100. Consider revising this logic. |
||
|
||
|
||
|
||
rabbit = Herbivore("Rabbit") | ||
print(rabbit) | ||
lion = Сarnivore("Lion") | ||
print(lion) | ||
|
||
|
||
lion.bite(rabbit) | ||
print(rabbit.health) | ||
lion.bite(rabbit) | ||
print(rabbit.health) | ||
print(Animal.alive) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
alive
list should be a class variable, not an instance variable. It should be defined asAnimal.alive = []
outside of the class definition to ensure it is shared across all instances.