Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding solution to py-herbivores-and-carnivores #1370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[flake8]
inline-quotes = "
ignore = E203, E266, W503, ANN002, ANN003, ANN101, ANN102, ANN401, N807, N818
max-line-length = 79
max-line-length = 86
max-complexity = 18
select = B,C,E,F,W,T4,B9,ANN,Q0,N8,VNE
exclude = venv, tests
32 changes: 31 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,31 @@
# write your code here
class Animal:
alive = []

def __init__(self, name: str, health: int = 100, hidden: bool = False) -> None:
self.name = name
self.health = health
self.hidden = hidden
Animal.alive.append(self)

def remove_from_alive(self) -> None:
if self in Animal.alive:
Animal.alive.remove(self)

def check(self) -> None:
if self.health <= 0:
self.remove_from_alive()

def __repr__(self) -> str:
return f'{{Name: {self.name}, Health: {self.health}, Hidden: {self.hidden}}}'


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
def bite(self, other: "Herbivore") -> None:
if isinstance(other, Herbivore) and not other.hidden:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the bite method is set to Herbivore. This could be restrictive if you later decide to allow Carnivores to bite other Carnivores or different types of animals. Consider using a more general type hint, like Animal, if you plan to extend this functionality.

other.health -= 50
other.check()
Loading