Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1381

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,30 @@
# write your code here
class Animal:
alive = []

def __init__(self, name: str, health: int = 100) -> None:
self.name: str = name
self.health: int = health
self.hidden: bool = False
if self.health > 0:
Animal.alive.append(self)

def __repr__(self) -> str:
return (f"{{Name: {self.name}, "
f"Health: {self.health}, Hidden: {self.hidden}}}")

@classmethod
def update_alive(cls) -> None:
cls.alive = [animal for animal in cls.alive if animal.health > 0]


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
def bite(self, prey: "Animal") -> None:
if isinstance(prey, Herbivore) and not prey.hidden:
prey.health -= 50
if prey.health <= 0:
Animal.update_alive()
Comment on lines +29 to +30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update_alive method should be called on the Animal class, not on an instance. The current implementation is correct in this regard, but ensure that the method is called whenever an animal's health changes to zero or below.