Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1397

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
47 changes: 46 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,46 @@
# write your code here
from __future__ import annotations
from typing import Union


class Animal:
alive = []

def __init__(self, name: str, health: int = 100) -> None:
self.name = name
self.health = health
self.hidden = False
Animal.alive.append(self)

def __str__(self) -> str:

return (f"Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}")

def __repr__(self) -> str:

return f"{{{self}}}"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you need to use only repr


class Herbivore(Animal):

def hide(self) -> None:
if not self.hidden:
self.hidden = True
return
self.hidden = False

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be a one-liner, please read a checklist!


class Carnivore(Animal):

@staticmethod
def bite(other: Union[Carnivore, Herbivore]) -> Union[str, None]:
if isinstance(other, Carnivore):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simply use str | None, without Union, it's not needed here

return "Carnivore won't bit Carnivore"
if isinstance(other, Herbivore):
if other.hidden:
return "Carnivore won't be able to bite hidden Herbivore"
if other.health > 0:
other.health -= 50
if other.health <= 0:
Animal.alive.pop(Animal.alive.index(other))
Loading