-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Solution' #1397
Open
Dogober
wants to merge
10
commits into
mate-academy:master
Choose a base branch
from
Dogober:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
'Solution' #1397
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4a917c6
'Solution'
Dogober 2569fd6
'simplification-bit-method'
Dogober 36c37c3
'rewrite-condition-into-Herbovire-hide-method'
Dogober f732fa5
'explicity-returntype-into-Carnovire-bite-method-and-del-unusefull-ch…
Dogober 2bd5d3b
'del_str_method'
Dogober e156b7e
'del-return-text-into-Carnovire-bite-method-and-del-return-type-str'
Dogober 8dfd528
'del-return-text-into-Carnovire-bite-method-and-del-return-type-str'
Dogober 005e21a
'simplify-bit-method'
Dogober dd57fcf
'deleting-unusefull-class-type-annotations-into-bite-method-and-simpl…
Dogober e90472e
'refactor-_repr_-method'
Dogober File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,37 @@ | ||
# write your code here | ||
from __future__ import annotations | ||
from typing import Union | ||
|
||
|
||
class Animal: | ||
alive = [] | ||
|
||
def __init__(self, name: str, health: int = 100) -> None: | ||
self.name = name | ||
self.hidden = False | ||
self.health = health | ||
Animal.alive.append(self) | ||
|
||
def __repr__(self) -> str: | ||
return (f"{{" | ||
f"Name: {self.name}, " | ||
f"Health: {self.health}, " | ||
f"Hidden: {self.hidden}}}") | ||
|
||
|
||
class Herbivore(Animal): | ||
|
||
def hide(self) -> None: | ||
self.hidden = not self.hidden | ||
|
||
|
||
class Carnivore(Animal): | ||
|
||
@staticmethod | ||
def bite(other: Union[Carnivore, Herbivore]) -> None: | ||
if isinstance(other, Carnivore): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. at can be simlified to Animal, as all of them is child of Animal, don't needed Union |
||
return | ||
if isinstance(other, Herbivore) and other.hidden: | ||
return | ||
other.health -= 50 | ||
if other.health <= 0: | ||
Animal.alive.pop(Animal.alive.index(other)) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have already put these brackets in a separate line, do the same at the end, or vice versa.