AnimalBiteAndDie #1401
AnimalBiteAndDie #1401
Conversation
app/main.py
Outdated
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| def bite(self, herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
You can implement this method as static, because you are not using any self-attributes here
There was a problem hiding this comment.
Ruslan is right, it must be a staticmethod
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
app/main.py
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
app/main.py
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
app/main.py
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
app/main.py
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
app/main.py
Outdated
| def __init__(self, name: str, health: int = 100, | ||
| hidden: bool = False) -> None: |
There was a problem hiding this comment.
One attribute per line, when you have a lot of attributes. At checklist you have a good example of styling
def long_function_name(
var_one,
var_two,
var_three,
var_four
) -> None:
app/main.py
Outdated
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| def bite(self, herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
Ruslan is right, it must be a staticmethod
No description provided.