Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,32 @@
# write your code here
class Animal:
alive = []

def __init__(self, name: str, health: int = 100) -> None:
self.name = name
self.health = health
self.hidden = False
Animal.alive.append(self)

def fun_delete(self) -> None:
Animal.alive.remove(self)

def __repr__(self) -> str:
return (f"{{Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}}}")


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
def bite(self, herbivore: Herbivore) -> None:
if isinstance(herbivore, Carnivore) or herbivore.hidden:
herbivore.health = herbivore.health

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition isinstance(herbivore, Carnivore) seems incorrect. The bite method is supposed to be used on Herbivore instances, so checking if herbivore is a Carnivore doesn't make sense. Consider removing this part of the condition.

else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't change the health of the herbivore. If the intention is to skip the health reduction when the herbivore is hidden, this line is fine. Otherwise, consider revising the logic.

herbivore.health -= 50

if herbivore.health <= 0:
herbivore.fun_delete()
Loading