Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1412

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ ignore = E203, E266, W503, ANN002, ANN003, ANN101, ANN102, ANN401, N807, N818
max-line-length = 79
max-complexity = 18
select = B,C,E,F,W,T4,B9,ANN,Q0,N8,VNE
exclude = venv, tests
exclude = venv, tests, .venv
43 changes: 42 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,42 @@
# write your code here
class Animal:
alive = []

def __init__(self,
name: str,
health: int = 100) -> None:
self.name = name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One attribute per line, when you have a lot of attributes. At checklist you have a good example of styling
def long_function_name(
        var_one,
        var_two,
        var_three,
        var_four
) -> None:

self.health = health
self.hidden = False
Animal.alive.append(self)

def __repr__(self) -> str:
return (f"{{Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}}}")

@classmethod
def remove_dead(cls) -> None:
cls.alive = [animal for animal in cls.alive if animal.health > 0]

@classmethod
def get_alive_repr(cls) -> str:
return str([repr(animal) for animal in cls.alive])

@classmethod
def get_alive(cls) -> list:
return cls.alive

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these methods isn't needed due to task requirements


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
@staticmethod
def bite(target: Animal) -> None:
if isinstance(target, Herbivore) and not target.hidden:
target.health -= 50
if target.health <= 0:
target.health = 0
Animal.alive.remove(target)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we don't need this assign

Loading