Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create task Herbivores and carnivores #1421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 55 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,55 @@
# write your code here
class Animal:
alive = []

def __init__(
self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:
self.name = name
self._health = health
self.hidden = hidden

Animal.alive.append(self)

def __str__(self) -> str:
return (
"{"
f"Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __str__ method is trying to access self.health, but health is a property. This is correct usage, but ensure that the property is functioning as expected.

"}"
)

def __repr__(self) -> str:
return str(self)

@property
def health(self) -> int:
return self._health

@health.setter
def health(
self,
new_health: int
) -> None:
if new_health > 0:
self._health = new_health
else:
self._health = 0
if self in Animal.alive:
Animal.alive.remove(self)


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
@staticmethod
def bite(other: Herbivore) -> None:
if isinstance(other, Herbivore):
if not other.hidden and other in Animal.alive:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isinstance check for Herbivore is redundant because the method signature already specifies other as a Herbivore. Consider removing this check to simplify the code.

other.health -= 50
Loading