Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New #1423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New #1423

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,29 @@
# write your code here
class Animal:
alive = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alive list is defined as a class variable, which is correct. However, ensure that this list is managed properly to avoid memory leaks or incorrect references if animals are frequently created and destroyed.

def __init__(self, name: str, health: int = 100) -> None:
self.name = name
self.health = health
self.hidden = False
Animal.alive.append(self)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending self to the Animal.alive list is correct for tracking living animals. Ensure that this logic aligns with the task requirements for managing animal states.

def __repr__(self) -> str:
return (f"{{Name: {self.name}, "
f"Health: {self.health}, Hidden: {self.hidden}}}")

def check_alive(self) -> None:
if self.health <= 0 and self in Animal.alive:
Animal.alive.remove(self)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check_alive method correctly removes the animal from the alive list if its health is zero or less. Ensure that this logic is consistent with the task requirements for managing animal states.


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hide method toggles the hidden state of a Herbivore. Ensure that this behavior is intended and aligns with the task requirements.


class Carnivore(Animal):
@staticmethod
def bite(herbivore: Herbivore) -> None:
if isinstance(herbivore, Herbivore) and not herbivore.hidden:
herbivore.health -= 50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bite method checks if the target is a Herbivore and not hidden before reducing its health. This logic is correct, but ensure that it aligns with the task requirements for interactions between Carnivore and Herbivore.

herbivore.check_alive()
Loading