created parent class Animal and two inherit classes #1424
Conversation
There was a problem hiding this comment.
Great job on implementing the class hierarchy for Animal, Herbivore, and Carnivore! 🎉 Your code meets the task requirements and constraints effectively. While there are a couple of minor issues, such as the shared alive list and the __str__ method being a class method, these do not significantly impact the functionality. Keep up the good work, and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @classmethod | ||
| def __str__(cls) -> str: |
There was a problem hiding this comment.
The __str__ method should not be a class method. It is typically an instance method that returns a string representation of an instance. Consider removing the @classmethod decorator and adjusting the method accordingly.
| @@ -2,0 +1,41 @@ | |||
| class Animal: | |||
| alive = [] | |||
There was a problem hiding this comment.
The alive list is a class variable, meaning it is shared among all instances of Animal. If the intention is to track all living animals across all instances, this is fine. However, if each instance should have its own list of 'alive' animals, consider making it an instance variable instead.
No description provided.