-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1430
base: master
Are you sure you want to change the base?
Solution #1430
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,30 @@ | ||
# write your code here | ||
class Animal: | ||
alive = [] | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
def __init__( | ||
self, | ||
name: str, | ||
health: int = 100, | ||
hidden: bool = False) -> None: | ||
self.name = name | ||
self.health = health | ||
self.hidden = hidden | ||
Animal.alive.append(self) | ||
|
||
def __repr__(self) -> str: | ||
return (f"{{Name: {self.name}, " | ||
f"Health: {self.health}, " | ||
f"Hidden: {self.hidden}}}") | ||
|
||
|
||
class Herbivore(Animal): | ||
def hide(self) -> None: | ||
self.hidden = not self.hidden | ||
|
||
|
||
class Carnivore(Animal): | ||
def bite(self, animal: Herbivore) -> None: | ||
if not animal.hidden and isinstance(animal, Herbivore): | ||
animal.health -= 50 | ||
if animal.health <= 0: | ||
Animal.alive.remove(animal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
alive
list is defined as a class attribute, which means it is shared across all instances ofAnimal
. This could lead to unexpected behavior if multiple instances are created. Consider makingalive
an instance attribute instead.