Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,41 @@
# write your code here
class Animal:
alive = []

def __init__(
self, name: str,
health: int = 100,
hidden: bool = False
) -> None:
self.name = name
self.health = health
self.hidden = hidden

Animal.alive.append(self)

def take_damage(self) -> None:
self.health -= 50
if self.health <= 0:
Animal.alive.remove(self)
return None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the take_damage method, before removing self from Animal.alive, you should check if self is actually in the list to prevent potential errors. Consider using a condition like if self in Animal.alive: before attempting to remove it.


def __repr__(self) -> str:
return f"{{Name: {self.name}, Health: {self.health}, Hidden: {self.hidden}}}"

@classmethod
def __str__() -> str:
return str([repr(animal) for animal in Animal.alive])
Comment on lines +24 to +25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __str__ method should not be a class method. It should be an instance method to provide a string representation of an instance of the class. Consider removing the @classmethod decorator and adjusting the method accordingly.



class Herbivore(Animal):
def hide(self) -> None:
if self.hidden is True:
self.hidden = False
else:
self.hidden = True
return None


class Carnivore(Animal):
def bite(self, herbivore: Herbivore) -> None:
if isinstance(herbivore, Herbivore) and herbivore.hidden is False:
herbivore.take_damage()
Loading