Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dima dev #1440

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,38 @@
# write your code here
class Animal:
alive = []

def __init__(
self,
name: str,
health: int = 100,
hidden: bool = False
) -> None :
self.name = name
self.health = health
self.hidden = hidden
Animal.alive.append(self)

def __repr__(self) -> str:
beg = "{"
end = "}"
return f"{beg}Name: {self.name}, " \
f"Health: {self.health}, " \
f"Hidden: {self.hidden}{end}"

Comment on lines +15 to +20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __repr__ method can be improved by using a single f-string for the entire return statement. This enhances readability and performance. Consider using: return f"{{Name: {self.name}, Health: {self.health}, Hidden: {self.hidden}}}".


class Herbivore(Animal):
def hide(self) -> None :
self.hidden = not self.hidden


class Carnivore(Animal):
@classmethod
def bite(cls, animal: Herbivore) -> None :
if isinstance(animal, Carnivore):
return
Comment on lines +30 to +31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bite method should explicitly check if animal is an instance of Herbivore to ensure that only herbivores are bitten. Consider adding a check like if not isinstance(animal, Herbivore): return to handle this case.

if animal.hidden:
return

Comment on lines +30 to +34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bite method should ensure that the animal parameter is an instance of Herbivore before proceeding. The current check isinstance(animal, Carnivore) is correct to prevent carnivores from biting each other, but it should also explicitly check if animal is a Herbivore to avoid errors if other types are passed.

animal.health -= 50
if animal.health <= 0:
Animal.alive.remove(animal)
Loading