-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dima dev #1440
base: master
Are you sure you want to change the base?
Dima dev #1440
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,38 @@ | ||
# write your code here | ||
class Animal: | ||
alive = [] | ||
|
||
def __init__( | ||
self, | ||
name: str, | ||
health: int = 100, | ||
hidden: bool = False | ||
) -> None : | ||
self.name = name | ||
self.health = health | ||
self.hidden = hidden | ||
Animal.alive.append(self) | ||
|
||
def __repr__(self) -> str: | ||
beg = "{" | ||
end = "}" | ||
return f"{beg}Name: {self.name}, " \ | ||
f"Health: {self.health}, " \ | ||
f"Hidden: {self.hidden}{end}" | ||
|
||
|
||
class Herbivore(Animal): | ||
def hide(self) -> None : | ||
self.hidden = not self.hidden | ||
|
||
|
||
class Carnivore(Animal): | ||
@classmethod | ||
def bite(cls, animal: Herbivore) -> None : | ||
if isinstance(animal, Carnivore): | ||
return | ||
Comment on lines
+30
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
if animal.hidden: | ||
return | ||
|
||
Comment on lines
+30
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
animal.health -= 50 | ||
if animal.health <= 0: | ||
Animal.alive.remove(animal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
__repr__
method can be improved by using a single f-string for the entire return statement. This enhances readability and performance. Consider using:return f"{{Name: {self.name}, Health: {self.health}, Hidden: {self.hidden}}}"
.