Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

herbivores #1441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,40 @@
# write your code here
class Animal:
alive = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alive list is defined as a class variable, which means it is shared across all instances of Animal. This is correct if you want to keep track of all alive animals globally. However, ensure this is the intended behavior, as it might lead to unexpected results if not managed carefully.

def __init__(
self, name: str,
health: int = 100,
hidden: bool = False
) -> None:
self.name = name
self.health = health
self.hidden = hidden
Animal.alive.append(self)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending self to the Animal.alive list in the constructor is correct for tracking alive animals. However, ensure that the check_health method is called appropriately to remove dead animals from this list.

def __repr__(self) -> str:
return (f"{{Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}}}")

def check_health(self) -> None:
if self.health <= 0:
if self in Animal.alive:
Animal.alive.remove(self)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check_health method removes the animal from the alive list if its health is zero or less. Ensure that this method is called whenever the animal's health changes to keep the list accurate.


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
@staticmethod
def bite(herbivore: Herbivore) -> None:
if isinstance(herbivore, Herbivore):
if not herbivore.hidden:
herbivore.health -= 50
herbivore.check_health()
else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bite method correctly reduces the health of the herbivore and calls check_health. However, ensure that the herbivore is an instance of Herbivore before calling this method, which is already checked by isinstance.

print(f"{herbivore.name} is hidden and cannot be bitten.")
else:
print("This is not a herbivore.")
Loading