Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1445

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,38 @@
# write your code here
class Animal:
alive = []

def __init__(self, name: str, health: int = 100) -> None:
self.name = name
self.health = health
self.__hidden = False
Animal.alive.append(self)

def __repr__(self) -> str:
return (f'{{Name: {self.name}, '
f'Health: {self.health}, '
f'Hidden: {self.__hidden}}}')

def die(self) -> None:
if self in Animal.alive:
Animal.alive.remove(self)

@property
def hidden(self) -> bool:
return self.__hidden

@hidden.setter
def hidden(self, value: bool) -> None:
self.__hidden = value


class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden

Comment on lines +29 to +30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hide method toggles the hidden property of the Herbivore class. While this works, it might be clearer to explicitly set the hidden property to True when hiding and False when revealing. This would make the intention of the method more explicit.


class Carnivore(Animal):
def bite(self, herbivore: "Herbivore") -> None:
if isinstance(herbivore, Herbivore) and not herbivore.hidden:
herbivore.health -= 50
if herbivore.health <= 0:
herbivore.die()
Loading