Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,40 @@
# write your code here
class Animal:

alive = []

def __init__(self, name: str, health: int = 100) -> None:
self.name = name
self.health = health
self.hidden = False
Animal.alive.append(self)

def die(self) -> None:
if self in Animal.alive:
Animal.alive.remove(self)

def __repr__(self) -> str:
return (
f"{{Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}}}"
)

@classmethod
def __str__(cls) -> str:
return str([str(animal) for animal in cls.alive])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __str__ method is incorrectly decorated with @classmethod. The __str__ method should not be a class method, as it is intended to provide a string representation of an instance, not the class itself. Consider removing the @classmethod decorator.



class Herbivore(Animal):

def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):

def bite(self, target: int) -> None:
if isinstance(target, Herbivore) and not target.hidden:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bite method's target parameter is typed as int, which is incorrect. It should be typed as Herbivore since the method checks if target is an instance of Herbivore. Consider changing the type annotation to Herbivore.

target.health -= 50
if target.health <= 0:
target.health = 0
target.die()
Loading