-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Solution' #1579
base: master
Are you sure you want to change the base?
'Solution' #1579
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,29 @@ | ||
# write your code here | ||
class Animal: | ||
alive = [] | ||
|
||
def __init__(self, name: str, health: int = 100, hidden: bool = False): | ||
self.health = health | ||
self.name = name | ||
self.hidden = hidden | ||
Animal.alive.append(self) | ||
|
||
def __str__(self): | ||
return (f"{{Name: {self.name}, Health: {self.health}, " | ||
f"Hidden: {self.hidden}}}") | ||
|
||
def __repr__(self): | ||
return (f"{{Name: {self.name}, Health: {self.health}, " | ||
f"Hidden: {self.hidden}}}") | ||
|
||
|
||
class Carnivore(Animal): | ||
def bite(self, herbivore): | ||
if isinstance(herbivore, Herbivore) and not herbivore.hidden: | ||
herbivore.health -= 50 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The condition |
||
if herbivore.health <= 0: | ||
Animal.alive.remove(herbivore) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing the herbivore from |
||
|
||
class Herbivore(Animal): | ||
def hide(self): | ||
self.hidden = not self.hidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
alive
list is a class variable, meaning it is shared across all instances ofAnimal
. If the intention is to track all living animals, this is correct. However, if each instance should have its own list, consider making it an instance variable instead.