Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #668

wants to merge 2 commits into from

Conversation

weuis
Copy link

@weuis weuis commented Sep 14, 2023

No description provided.

app/main.py Outdated
Comment on lines 7 to 8
health: int | None = 100,
hidden: bool | None = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type annotations is incorrect because it suggests that these parameters can be assigned the value None, which contradicts their intended use of having default values 100 and False, respectively

Copy link
Contributor

@viktoria-rybenchuk viktoria-rybenchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants