Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #675

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

solution #675

wants to merge 10 commits into from

Conversation

Andru37
Copy link

@Andru37 Andru37 commented Sep 18, 2023

No description provided.

app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@Andru37 Andru37 requested a review from EdAlekseiev September 20, 2023 11:31
app/main.py Outdated Show resolved Hide resolved
@Andru37 Andru37 requested a review from YukihiroSM September 20, 2023 15:21
Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix flake8

@Andru37 Andru37 requested a review from EdAlekseiev September 25, 2023 18:25
app/main.py Outdated
class Carnivore(Animal):

@staticmethod
def bite(other: object) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect type hint for other

@Andru37 Andru37 requested a review from EdAlekseiev September 25, 2023 19:44
app/main.py Outdated
Comment on lines 5 to 9
def __init__(self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __init__(self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:
def __init__(
self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I doing it. I have a mistake.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it all back.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And i have not a mistake.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is OK on my machine
not just do like I mentioned but reformat code a bit
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am stupid. All is good.

app/main.py Outdated
Comment on lines 5 to 9
def __init__(self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is OK on my machine
not just do like I mentioned but reformat code a bit
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants