Solution #679
Solution #679
Conversation
app/main.py
Outdated
| target.health -= 50 \ | ||
| if (isinstance(target, Herbivore) and not target.hidden) else 0 |
There was a problem hiding this comment.
Write this code in multiple lines to avoid line-breaking with \. Besides that, if the target is an instance of Carnivore, or it is hidden its health would always equal 0 in your current version.
app/main.py
Outdated
|
|
||
| class Carnivore(Animal): | ||
|
|
||
| def bite(self, target: Union) -> None: |
There was a problem hiding this comment.
Change your type annotation for the target to indicate that you expect a Herbivore instance.
app/main.py
Outdated
| def bite(self, target: Union) -> None: | ||
| target.health -= 50 \ | ||
| if (isinstance(target, Herbivore) and not target.hidden) else 0 | ||
| Animal.remove_dead_animal() |
There was a problem hiding this comment.
It would be inefficient to make a perform list comprehension and create a new list each time after the animal is deleted from the alive. Use .remove(target) to perform deletion in place and implement this logic inside of the bite method, delete the remove_dead_animal class method from the Animal class.
app/main.py
Outdated
| self.name = name | ||
| self.health = health | ||
| self.hidden = hidden | ||
| self.alive.append(self) |
There was a problem hiding this comment.
Refer to Animal.alive instead of self.alive, because alive is a class attribute.
app/main.py
Outdated
| @@ -1 +1,38 @@ | |||
| # write your code here | |||
| from typing import Union | |||
There was a problem hiding this comment.
Do not forget to remove unnecessary imports.
app/main.py
Outdated
| self, | ||
| name: str, | ||
| health: int = 100, | ||
| hidden: bool = False) -> None: |
There was a problem hiding this comment.
Place ) -> None: on a new line to format your code properly.
app/main.py
Outdated
| self.name = name | ||
| self.health = health | ||
| self.hidden = hidden | ||
| self.alive.append(self) |
app/main.py
Outdated
| self.name = name | ||
| self.health = health | ||
| self.hidden = hidden | ||
| self.alive.append(self) |
There was a problem hiding this comment.
Append the current instance to the class attribute 'alive'
app/main.py
Outdated
| self.alive.append(self) | ||
|
|
||
| @classmethod | ||
| def remove_dead_animal(cls, animal: Type[Herbivore]) -> None: |
There was a problem hiding this comment.
| def remove_dead_animal(cls, animal: Type[Herbivore]) -> None: | |
| def remove_dead_animal(cls, animal: Herbivore) -> None: |
No description provided.