Solution #714
Open
Solution #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Oct 9, 2023
app/main.py
Outdated
Comment on lines
28
to
29
| for item in Animal.alive: | ||
| if item.name == animal.name: |
There was a problem hiding this comment.
Really is it possible that other hp can change?
There was a problem hiding this comment.
do I need to check in some other way? the list always has 1 predator and 1 herbivore, can there be more?
Yurnerroo
suggested changes
Oct 9, 2023
tests/test_main.py
Outdated
| @@ -15,7 +15,7 @@ def test_animal_class(): | |||
|
|
|||
|
|
|||
| def test_animal_constructor(): | |||
| lion = Animal("Lion King") | |||
| lion = Animal("Lion King", ) | |||
app/main.py
Outdated
Comment on lines
23
to
28
| if (animal.hidden or animal not in animal.alive | ||
| or not isinstance(animal, Herbivore)): | ||
| return | ||
| animal.health -= 50 | ||
| if animal.health <= 0: | ||
| Animal.alive.remove(animal) |
There was a problem hiding this comment.
I changed it, but I'm not sure that it's better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.